image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard

Add more OCI builder properties

Open kkeshavamurthy opened this issue 2 years ago • 2 comments

What this PR does / why we need it: Added a few more oci builder properties that would be useful for image-building.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context Add any other context for the reviewers

kkeshavamurthy avatar Aug 11 '22 16:08 kkeshavamurthy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkeshavamurthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 11 '22 16:08 k8s-ci-robot

@mkumatag PTAL

kkeshavamurthy avatar Aug 15 '22 16:08 kkeshavamurthy

overall lgtm but need another pair of eyes. /lgtm /hold

mkumatag avatar Aug 22 '22 10:08 mkumatag

/lgtm

SanikaGawhane avatar Aug 22 '22 20:08 SanikaGawhane

Thanks @mkumatag @SanikaGawhane

kkeshavamurthy avatar Aug 22 '22 20:08 kkeshavamurthy

/hold cancel

kkeshavamurthy avatar Aug 22 '22 20:08 kkeshavamurthy