image-builder
image-builder copied to clipboard
kubernetes-sigs
use pause image from mcr.microsoft.com for azure images
Signed-off-by: Mark Rossetti [email protected]
What this PR does / why we need it:
This PR makes it so the pause/infra image used when building Azure VHDs comes from mcr.microsoft.com.
Which issue(s) this PR fixes (optional, in fixes #
Additional context Add any other context for the reviewers
I'm running some builds locally and have verified that this setting is being correctly picked up/passed to ansible
==> vhd-windows-2019-containerd: Executing Ansible: ansible-playbook -e packer_build_name="vhd-windows-2019-containerd" -e packer_builder_type=azure-arm -e ansible_winrm_server_cert_validation=ignore ansible_winrm_operation_timeout_sec=120 ansible_winrm_read_timeout_sec=150 --extra-vars runtime=containerd docker_ee_version=19.03.12 containerd_url=https://github.com/containerd/containerd/releases/download/v1.6.2/containerd-1.6.2-windows-amd64.tar.gz containerd_sha256=4fdf1850a132599cf679992d8405a54416a5ab2982959db20d969054c40a2b71 pause_image=mcr.microsoft.com/oss/kubernetes/pause:3.8
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: marosset, mboersma
Once this PR has been reviewed and has the lgtm label, please ask for approval from jsturtevant by writing /assign @jsturtevant in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This might be confusing to a user or they may wish to use the upstream images.
If we used a configuration step in our pipelines that produce the images we could overload it there like we do with the k8s version
+1 to @jsturtevant's comment, this might not be the best place to configure it if we're just looking to change the image for the reference images we build. However, it might be worth making it easier to use all the MCR images long-term with some opt-in flag or variable for the Azure build as I could see that being a common use case not just for reference images but for first/third party users as well.
This might be confusing to a user or they may wish to use the upstream images. If we used a configuration step in our pipelines that produce the images we could overload it there like we do with the k8s version
+1 to @jsturtevant's comment, this might not be the best place to configure it if we're just looking to change the image for the reference images we build. However, it might be worth making it easier to use all the MCR images long-term with some opt-in flag or variable for the Azure build as I could see that being a common use case not just for reference images but for first/third party users as well.
ack, I'll look into different ways this can be specified. Thanks!
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
@marosset: Closed this PR.
In response to this:
/close
we can re-activate if needed
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.