image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard

Add GPU driver enabled Ubuntu(18.04 & 20.04) GCE image

Open aniruddha2000 opened this issue 3 years ago • 38 comments

What this PR does / why we need it:

Creates the Ubuntu (18.04 & 20.04) GCE image with GPU drivers pre-installed.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context Waiting for 907 to be merged so that we can be sure about the ssh connection.

aniruddha2000 avatar Jul 08 '22 15:07 aniruddha2000

Welcome @aniruddha2000!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 08 '22 15:07 k8s-ci-robot

Hi @aniruddha2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 08 '22 15:07 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aniruddha2000 To complete the pull request process, please assign enxebre after the PR has been reviewed. You can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 08 '22 15:07 k8s-ci-robot

/cc @dims @richardcase @cpanato

aniruddha2000 avatar Jul 08 '22 15:07 aniruddha2000

/ok-to-test

And until #907 merges:

/hold

richardcase avatar Jul 08 '22 15:07 richardcase

@aniruddha2000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
json-sort-check fbdb539a0b7c3696c3393e3bb9f60b5a0005119f link true /test json-sort-check
pull-packer-validate fbdb539a0b7c3696c3393e3bb9f60b5a0005119f link true /test pull-packer-validate
pull-azure-sigs fbdb539a0b7c3696c3393e3bb9f60b5a0005119f link false /test pull-azure-sigs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jul 08 '22 16:07 k8s-ci-robot

cc @codenrhoden for visibility

cpanato avatar Jul 09 '22 09:07 cpanato

/cc @codenrhoden

aniruddha2000 avatar Jul 09 '22 15:07 aniruddha2000

@aniruddha2000 are you still working on this? (looks like it is marked as draft/WIP)

dims avatar Aug 23 '22 12:08 dims

@dims - it’s waiting for #907 to merge. Although we could probably work around this...wdyt @aniruddha2000 @SubhasmitaSw ?

richardcase avatar Aug 23 '22 13:08 richardcase

Yes @dims @richardcase we should go for a workaround

aniruddha2000 avatar Aug 23 '22 14:08 aniruddha2000

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 21 '22 15:11 k8s-triage-robot

/remove-lifecycle stale

mboersma avatar Dec 07 '22 22:12 mboersma

I am picking this up again after the holidays.

richardcase avatar Jan 03 '23 11:01 richardcase

The https://github.com/kubernetes-sigs/image-builder/pull/907 is closed then we should add the changes by ourselves then.

aniruddha2000 avatar Feb 13 '23 07:02 aniruddha2000

@aniruddha2000 #907 was closed since #1035 was merged. Does that help you proceed with this PR?

kkeshavamurthy avatar Feb 14 '23 09:02 kkeshavamurthy

@aniruddha2000 - looks like there are some test failures. Any chance you could take a look?

richardcase avatar Feb 22 '23 17:02 richardcase

@richardcase I think all are green.

aniruddha2000 avatar Feb 24 '23 18:02 aniruddha2000

And until https://github.com/kubernetes-sigs/image-builder/pull/907 merges:

/hold

@richardcase @aniruddha2000 this had a hold until 907 merged but that looks like it got closed. Is this still needed?

jsturtevant avatar May 23 '23 20:05 jsturtevant

/retest-required

whtssub avatar Jul 12 '23 09:07 whtssub

@SubhasmitaSw The tests wont pass until this PR has been rebased as there are currently conflicts.

@aniruddha2000 Any chance you can rebase this PR? (and remove 18.04 as it's no longer available on GCE)

AverageMarcus avatar Jul 13 '23 05:07 AverageMarcus

@AverageMarcus yes will do

aniruddha2000 avatar Jul 13 '23 06:07 aniruddha2000

@aniruddha2000 This PR has been open for ~14mo now. If this is still needed please address the comments and get it merged in the next couple of weeks. If not, I'll close this PR and you can open up a new one when needed.

kkeshavamurthy avatar Aug 28 '23 15:08 kkeshavamurthy

@aniruddha2000 let me know if i can help with this.

richardcase avatar Aug 31 '23 05:08 richardcase

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jsturtevant for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 03 '23 04:09 k8s-ci-robot

@richardcase rebased, could you take over this now? I have very little bandwidth to take this

aniruddha2000 avatar Sep 03 '23 04:09 aniruddha2000

@aniruddha2000 - thanks for the rebase. It looks like are a few validation errors.

richardcase avatar Sep 04 '23 16:09 richardcase

/test pull-ova-all

kkeshavamurthy avatar Sep 15 '23 17:09 kkeshavamurthy

/retest

These errors should be fixed now that #1320 merged.

mboersma avatar Oct 12 '23 15:10 mboersma

Thanks @mboersma

aniruddha2000 avatar Oct 12 '23 15:10 aniruddha2000

Looks like the tests are passing, @aniruddha2000 there are a few open comments on the PR, could you address them and then I think we can move forward with the PR.

jsturtevant avatar Nov 07 '23 16:11 jsturtevant

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 05 '24 17:02 k8s-triage-robot