image-builder
image-builder copied to clipboard
Add GPU driver enabled Ubuntu(18.04 & 20.04) GCE image
What this PR does / why we need it:
Creates the Ubuntu (18.04 & 20.04) GCE image with GPU drivers pre-installed.
Which issue(s) this PR fixes (optional, in fixes #
Additional context Waiting for 907 to be merged so that we can be sure about the ssh connection.
Welcome @aniruddha2000!
It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @aniruddha2000. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: aniruddha2000
To complete the pull request process, please assign enxebre after the PR has been reviewed.
You can assign the PR to them by writing /assign @enxebre in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/cc @dims @richardcase @cpanato
/ok-to-test
And until #907 merges:
/hold
@aniruddha2000: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| json-sort-check | fbdb539a0b7c3696c3393e3bb9f60b5a0005119f | link | true | /test json-sort-check |
| pull-packer-validate | fbdb539a0b7c3696c3393e3bb9f60b5a0005119f | link | true | /test pull-packer-validate |
| pull-azure-sigs | fbdb539a0b7c3696c3393e3bb9f60b5a0005119f | link | false | /test pull-azure-sigs |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
cc @codenrhoden for visibility
/cc @codenrhoden
@aniruddha2000 are you still working on this? (looks like it is marked as draft/WIP)
@dims - it’s waiting for #907 to merge. Although we could probably work around this...wdyt @aniruddha2000 @SubhasmitaSw ?
Yes @dims @richardcase we should go for a workaround
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
I am picking this up again after the holidays.
The https://github.com/kubernetes-sigs/image-builder/pull/907 is closed then we should add the changes by ourselves then.
@aniruddha2000 #907 was closed since #1035 was merged. Does that help you proceed with this PR?
@aniruddha2000 - looks like there are some test failures. Any chance you could take a look?
@richardcase I think all are green.
And until https://github.com/kubernetes-sigs/image-builder/pull/907 merges:
/hold
@richardcase @aniruddha2000 this had a hold until 907 merged but that looks like it got closed. Is this still needed?
/retest-required
@SubhasmitaSw The tests wont pass until this PR has been rebased as there are currently conflicts.
@aniruddha2000 Any chance you can rebase this PR? (and remove 18.04 as it's no longer available on GCE)
@AverageMarcus yes will do
@aniruddha2000 This PR has been open for ~14mo now. If this is still needed please address the comments and get it merged in the next couple of weeks. If not, I'll close this PR and you can open up a new one when needed.
@aniruddha2000 let me know if i can help with this.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jsturtevant for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@richardcase rebased, could you take over this now? I have very little bandwidth to take this
@aniruddha2000 - thanks for the rebase. It looks like are a few validation errors.
/test pull-ova-all
/retest
These errors should be fixed now that #1320 merged.
Thanks @mboersma
Looks like the tests are passing, @aniruddha2000 there are a few open comments on the PR, could you address them and then I think we can move forward with the PR.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale