image-builder
image-builder copied to clipboard
kubernetes-sigs
images/capi/packer/azure: small SIG related improvements and fixes
What this PR does / why we need it:
See commit messages for more details.
Additional context
Identified while working on https://github.com/flatcar-linux/Flatcar/issues/734.
/lgtm @invidian If this PR is good to go can you please squash the commits
@invidian If this PR is good to go can you please squash the commits
Thanks for having a look. I've rebased the PR and it's ready to go. I wouldn't squash the commits though, as they are distinct and of good quality.
looks related to pip:
Complete output from command python setup.py egg_info:\n Traceback (most recent call last):\n File \"<string>\", line 1, in <module>\n File \"/tmp/pip-build-ixrvk6wk/bcrypt/setup.py\", line 11, in <module>\n from setuptools_rust import RustExtension\n ModuleNotFoundError: No module named 'setuptools_rust'\n \n =============================DEBUG ASSISTANCE==========================\n If you are seeing an error here please try the following to\n successfully install cryptography:\n \n Upgrade to the latest pip and try again. This will fix errors for most\n users. See: https://pip.pypa.io/en/stable/installing/#upgrading-pip\n =============================DEBUG ASSISTANCE==========================\n \n \n ----------------------------------------\n\n:stderr: Command \"python setup.py egg_info\" failed with error code 1 in /tmp/pip-build-ixrvk6wk/bcrypt/\n"}[0m
We've had some issue with it in the past but his looks slightly different https://github.com/kubernetes-sigs/image-builder/issues/766
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: invidian, jsturtevant
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~images/capi/packer/azure/OWNERS~~ [jsturtevant]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
