image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard
verified publisher icon kubernetes-sigs

Improve bootstrap-flatcar.sh

Open kopiczko opened this issue 3 years ago • 10 comments

There were two issues I had:

  • PYTHON_VERSION was not defined (only PYTHON3_VERSION) and set -o nounset helps catching that
  • set -o errexit is the same as set -e so there is no change in that regard
  • I think set -o pipefail just makes sense with set -o errexit

I also added:

  • set -x - to make the debugging easier
  • replaced wget -O - with curl -sfL to reduce the amount of output , because wget is printing all those dots and it's difficult to control that

Extracted from https://github.com/kubernetes-sigs/image-builder/pull/907

kopiczko avatar Jun 17 '22 18:06 kopiczko

Hi @kopiczko. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 17 '22 18:06 k8s-ci-robot

/assign

kopiczko avatar Jun 17 '22 18:06 kopiczko

CC @invidian @johananl

kopiczko avatar Jun 17 '22 18:06 kopiczko

/ok-to-test

mboersma avatar Jun 18 '22 13:06 mboersma

/assign @enxebre

kopiczko avatar Jun 20 '22 19:06 kopiczko

/test pull-azure-sigs

This should run to test Flatcar builds and I expect it to fail because of missing #907.

invidian avatar Jun 23 '22 11:06 invidian

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 29 '22 05:09 k8s-triage-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: invidian, johananl, kopiczko Once this PR has been reviewed and has the lgtm label, please ask for approval from enxebre by writing /assign @enxebre in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 30 '22 09:09 k8s-ci-robot

/lgtm

johananl avatar Sep 30 '22 10:09 johananl

/remove-lifecycle stale

johananl avatar Oct 13 '22 15:10 johananl

/lgtm /approve

kkeshavamurthy avatar Nov 21 '22 21:11 kkeshavamurthy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invidian, johananl, kkeshavamurthy, kopiczko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 21 '22 21:11 k8s-ci-robot