kubernetes-sigs
Feat add azure arm64 support
Change description
Add support for Azure Arm64 builds:
- Added variables for architecture where necessary.
- Removed support for deprecated azure managed instances https://learn.microsoft.com/en-us/azure/virtual-machines/migration/migration-managed-image-to-compute-gallery?tabs=portal
- Upgraded azure packer plugin
- Is this change including a new Provider or a new OS? (y/n) n
- If yes, has the Provider/OS matrix been updated in the readme? (y/n) n
- If adding a new provider, are you a representative of that provider? (y/n) n
Related issues
Additional context
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @natitomattis. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Removed support for deprecated azure managed instances learn.microsoft.com/en-us/azure/virtual-machines/migration/migration-managed-image-to-compute-gallery?tabs=portal
Is this change required for this PR? If not I think it might be best to have it in its own PR so we can specifically call this out in the changelog.
Would you mind squashing your commits too please?
/ok-to-test
@natitomattis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-azure-sigs | 7f930a724e0b197f55a923b112576e46af56205b | link | false | /test pull-azure-sigs |
| pull-azure-vhds | 7f930a724e0b197f55a923b112576e46af56205b | link | true | /test pull-azure-vhds |
| pull-packer-validate | 7f930a724e0b197f55a923b112576e46af56205b | link | true | /test pull-packer-validate |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
😞 Looks like we're blocked by this: https://github.com/hashicorp/packer-plugin-azure/issues/526
On my environment I've followed the steps described here and I could install it. Probably I'll need to update the installation on this repo as well
@AverageMarcus Sorry I just saw this comment:
Is this change required for this PR? If not I think it might be best to have it in its own PR so we can specifically call this out in the changelog.
Yes it is required, since the base ARM image doesn't require the pan information. If we add the plan details it fails.
FYI - we're discussing the issue with the plugin install change on Slack here: https://kubernetes.slack.com/archives/C01E0Q35A8J/p1754927876822259
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten