kubernetes-sigs
MAAS: Support both UEFI and BIOS boot modes in setup-bootloader
Change description
Add support for both UEFI and BIOS boot modes in setup-bootloader only in MAAS Provider
This change updates the setup-bootloader script to detect the system's firmware type (UEFI or BIOS) and install the appropriate GRUB bootloader.
- If UEFI is detected, grub-efi is configured and installed.
- If BIOS is detected, grub-efi is removed, grub-pc is installed, and GRUB is installed to the appropriate disk.
- Improved script comments to reflect modifications by the image-builder team.
- Maintains compatibility with systems lacking UEFI support.
This ensures broader hardware compatibility for the generated images.
Related issues
- Fixes #
Additional context
@vasartori: GitHub didn't allow me to assign the following users: gabrielalves87.
Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @vasartori @gabrielalves87
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@vasartori: you cannot LGTM your own PR.
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AverageMarcus
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [AverageMarcus]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@AverageMarcus could you please approve this PR? I have tested it, and @gabrielalves87 has also tested. Everything is working fine.
😆 Beat you to it!
Once the tests have re-run successfully it'll automatically merge :)
😆 Beat you to it!
Once the tests have re-run successfully it'll automatically merge :)
😆😆😆😆😆 You were lightning-fast!
Thanks a lot Marcus!