Update the OVA test script to dynamically detect targets to test
Change description
Updates the OVA test script to dynamically detect target OSs we support and run tests for those. We also filter out the following:
- Any RHEL targets (because of subscription requirements)
- Any Windows targets (because of license requirements)
- Any efi targets (to reduce duplicate OSs)
This results in, currently, the following targets:
build-node-ova-vsphere-centos-7
build-node-ova-vsphere-photon-3
build-node-ova-vsphere-photon-4
build-node-ova-vsphere-photon-5
build-node-ova-vsphere-rockylinux-8
build-node-ova-vsphere-rockylinux-9
build-node-ova-vsphere-ubuntu-2004
build-node-ova-vsphere-ubuntu-2204
build-node-ova-vsphere-ubuntu-2404
build-node-ova-vsphere-flatcar
Related issues
- Towards improving https://github.com/kubernetes-sigs/image-builder/issues/1605
Additional context
/retest
It this for flatcar:
[1;31mBuild 'vsphere-iso.vsphere' errored after 2 minutes 14 seconds: Post "https://192.168.31.2/sdk": dial tcp 192.168.31.2:443: connect: connection timed out[0m
We did see a similar thing in CAPV too.
Let's add something to e2e.sh to wait for the connection to be up, like here (without the if part), maybe needs to replace VSPHERE_SERVER by GOVC_URL or so:
https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/hack/e2e.sh#L141-L166
Looks like the filtering isn't working correctly with that version of grep anyway. 🤦 I'll pick this back up later. Will convert to WIP for now.
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
RockyLinux-8 is failing with
Build 'vsphere-iso.vsphere' errored after 3 seconds 634 milliseconds: No host is compatible with the virtual machine.
Is it possibly an incompatibility with the version of vsphere? Maybe we just need to exclude this one too?
/test pull-ova-all
/test pull-ova-all
/test pull-ova-all
/lgtm
/assign @mboersma
/lgtm
For rocky 8: it propably needs something similar to:
https://github.com/kubernetes-sigs/image-builder/blob/main/images/capi/packer/ova/rockylinux-9.json#L19
But fine as follow-up.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mboersma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mboersma]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment