image-builder
image-builder copied to clipboard
kubernetes-sigs
Add flatcar build for Proxmox
Change description
This PR adds:
- Flatcar build for Proxmox
Related issues
- Fixes #
Additional context
WIP in CAPMOX https://github.com/ionos-cloud/cluster-api-provider-proxmox/pull/308
but I will provide a link to how this works in the provider once it is released.
@mboersma @drew-viles What do y'all think about this currently requiring the use of the Alpha Flatcar builds? I'm kinda inclined to not include this in image-builder until it's available in the Stable channel but I'm open to being convinced otherwise.
The PROXMOX VE image, was tested really well with a lot of parties. And is being added to the alpha channel as that the release process.
On the other hand The image builder has the ability to set Flatcar Channel, Well in that case if you only accept stable Channel, there is no need for that variable. i.e. I tried to use the features provided.
I'm more concerned about it defaulting to Alpha channel.
If user chose to use non-stable channels that's fine but I think the out-of-the-box settings should encourage stability. (Especially true as we're not in a position to provide any support or testing for Proxmox and very limited for Flatcar so if anyone has any issues they are often on their own)
capmox will have the support soon. https://github.com/ionos-cloud/cluster-api-provider-proxmox/pull/308
@drew-viles @jsturtevant do either of you have time to look at this as well?
(@AverageMarcus is away until 2025, so I may ask for more review help, or just lgtm+approve a bunch of things myself, mea culpa.)
In terms of running the alpha as the default, I have no major opinion on it as I don't use flatcar so can't really comment on the stability of the alpha. It seems a bit brave but if it's been tested and we can be sure it stays stable enough I'm happy to go with the crowd.
I'm back from vacation now but will be out again in 2 weeks until Jan so get all the PRs you can in over those two weeks 🤣
I can approved once the squash has happened
Hi, regarding Alpha channel concerns, this will not be true anymore. In a few days, we will promote the Proxmox feature to "Beta" and we are confident enough to encourage folks to run a few Beta nodes in their workloads.
Squash is done, I will make sure to update the docs when the Proxmox VE will be in the Beta channel.
Squash is done, I will make sure to update the docs when the Proxmox VE will be in the Beta channel.
Now live. :pray:
/hold
@mcbenjemaa could you squash the commits?
@mboersma Remove hold label and we are good to go
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: drew-viles, mboersma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [drew-viles,mboersma]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
