headlamp icon indicating copy to clipboard operation
headlamp copied to clipboard

docker-ext: Add files required to build docker ext

Open yolossn opened this issue 3 years ago • 9 comments

To Do:

  • [ ] Add Docker login creds to repo secrets.

yolossn avatar Aug 30 '22 10:08 yolossn

Is this still a draft? If not, let me know and I'll review it :)

illume avatar Sep 02 '22 08:09 illume

Is this still a draft? If not, let me know and I'll review it :)

Have to add make recipe for building the docker extension and pushing the extension to dockerhub.

yolossn avatar Sep 05 '22 04:09 yolossn

I found this page with a checklist of things to do before submitting the extension: https://www.docker.com/products/extensions/submissions/

In it was a section on running "validate": https://docs.docker.com/desktop/extensions-sdk/build/build-install/#validate-your-extension

$ docker extension validate headlamp
label "com.docker.extension.additional-urls" is not specified. You can provide more detailed information to users about your extension.
could not parse image into name and tag

I'm wonder if there should be a make target for validate as well? Or maybe just in the README.md?

illume avatar Sep 06 '22 18:09 illume

Edit: So... I restarted Docker Desktop, and it shows up now. (Maybe mention that in the README? I guess they will fix that eventually though).


After I installed it via the command line (gitbash) on windows it doesn't show up in docker desktop. hrmm.

image

illume avatar Sep 06 '22 18:09 illume

When I click to open the Headlamp extension it doesn't seem to do anything. Just a blank screen.

Then I clicked on the left hand icon again... and up pops Headlamp. But is stuck on "fetching clusters". image

I'm not sure how to debug it or get logs for it... do you know?

illume avatar Sep 06 '22 18:09 illume

Part of the extention check list is following their design and UI guidelines. https://www.docker.com/products/extensions/submissions/

In there they talk about using mui (we are still on material ui 4) with their theme. So probably before we submit it we should do that. We have that mui v5 upgrade PR still open here: https://github.com/kinvolk/headlamp/pull/668 (it's still a bit buggy but 'works').

illume avatar Sep 06 '22 18:09 illume

When I click to open the Headlamp extension it doesn't seem to do anything. Just a blank screen.

Then I clicked on the left hand icon again... and up pops Headlamp. But is stuck on "fetching clusters".

Enable the kubernetes cluster from docker desktop settings before installing the headlamp addon, then it wont get stuck in "fetching clusters" stage. (Added this step to Readme)

image

yolossn avatar Sep 07 '22 06:09 yolossn

Part of the extention check list is following their design and UI guidelines. https://www.docker.com/products/extensions/submissions/

I am not sure if this is compulsory for submitting the extension, I don't see other extensions using the docker desktop theme. So I think we can solve this once #668 is merged.

yolossn avatar Sep 07 '22 06:09 yolossn

Enable the kubernetes cluster from docker desktop settings before installing the headlamp addon, then it won't get stuck in "fetching clusters" stage. (Added this step to Readme)

Cool, thanks. I tried turning k8s on and off again. Restarting docker desktop. Uninstalling headlamp extension... and now the extension won't install... the docker extension install command just hangs. I'm not having much luck here.

hrmm. Not sure what else to try. I think the problems I having are related to Docker Desktop and the beta part of the "extensions beta" rather than a problem with the extension itself.

I am not sure if this is compulsory for submitting the extension, I don't see other extensions using the docker desktop theme. So I think we can solve this once https://github.com/kinvolk/headlamp/pull/668 is merged.

Yeah, that was my thinking too. Submit it and see what they say. It's already matching pretty close I guess using material ui and such.

illume avatar Sep 07 '22 08:09 illume