kubernetes-sigs
frontend: Remove broken node List.stories.tsx
This story is broken, so removing it for now.
- It is always failing in the storybook.
- It is intermittently failing for me locally in the test runner.
Related to
- #2450
- #1282
How were you able to pinpoint the issue to List? I tried to test storybook in both branches to break it, and this is what I found:
- Loading the storybook home (
http://localhost:6006) usually does not cause any components to fail. Even in main, once the home view opens, you can click around, and even the List test does not fail. - Loading a component in storybook (i.e.
http://localhost:6006/?path=/story/resource-maininfosection--null-backlink) and refreshing on this page will eventually cause storybook to fail with similar messages to what you've posted, both in main and the node-story branch. This isn't unique to List though, I've attached some sample screenshots below.
Is this something we can look to change? Or is this the nature of how storybook works? (as in, storybook will basically be unusable if a single story isn't able to render)
@skoeva thanks for sharing that. I added your notes into here:
- https://github.com/headlamp-k8s/headlamp/issues/2450
How were you able to pinpoint the issue to List?
For me it's just this one thing that intermittently fails locally with the test runner. I can see other ones failing like you mentioned.
Is this something we can look to change? Or is this the nature of how storybook works? (as in, storybook will basically be unusable if a single story isn't able to render)
Yeah we should fix it. They should be working when one component fails. I haven't bisected it yet... but some months ago those stories were working, so it's something since then.
Since now that one isn't failing for me either.
Still have this issue open for the storybook issues: https://github.com/headlamp-k8s/headlamp/issues/2450