gcp-filestore-csi-driver
gcp-filestore-csi-driver copied to clipboard
kubernetes-sigs
issue-639: Add labels from command line option to filestore backup resource
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test
/kind feature
/kind flake
What this PR does / why we need it: Adds labels from command line option to the filestore backup resource. Adding this change would keep the labels behavior in uniform with what's supported for filestore instance resource. Labels added by driver, user defined labels in StorageClass object and labels passed through command line are parsed with precedence in the listed order.
Which issue(s) this PR fixes:
Fixes #639
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Hi @bharath-b-rh. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
IMO, this might just be considered a bug fix. /lgtm /ok-to-test /assign @mattcary for approval
@bharath-b-rh: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:
-
/test pull-gcp-filestore-csi-driver-e2e -
/test pull-gcp-filestore-csi-driver-kubernetes-integration -
/test pull-gcp-filestore-csi-driver-sanity -
/test pull-gcp-filestore-csi-driver-unit -
/test pull-gcp-filestore-csi-driver-verify
Use /test all to run all jobs.
In response to this:
/retest pull-gcp-filestore-csi-driver-kubernetes-integration
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bharath-b-rh, leiyiz, pwschuurman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [leiyiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@bharath-b-rh: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.
In response to this:
/cherry-pick release-1.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pwschuurman / @leiyiz Could you please help me with cherry picking this change to release-1.6. Thank you!
@mattcary: new pull request created: #888
In response to this:
/cherry-pick release-1.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.