gcp-filestore-csi-driver
gcp-filestore-csi-driver copied to clipboard
kubernetes-sigs
issue-567: Support to add ResoureManagerTags to GCP Filestore resources
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test
/kind feature
/kind flake
What this PR does / why we need it:
PR is for attaching user desired tags to filestore Instance resources created by the driver. New argument resource-tags is added to accept tags from users. Please refer issue-567 for more details.
Which issue(s) this PR fixes:
Fixes #567
Special notes for your reviewer: PR adds changes for configuring tags for filestore Instance resources, which is accepted from user as an argument holding comma separated values. Driver adds tags to the after creating filestore Instance resources. GCP tags writes have quota limit and implementation has handling for limiting request rate and handling quota exceeded errors.
Implementation does not create tag key or tag value resources and expects these resources to exist beforehand, otherwise driver would fail to start with tag processing error.
GCP credentials account shared with the driver requires roles/resourcemanager.tagUser permission for tag binding operations, which needs to be documented.
Does this PR introduce a user-facing change?:
Yes
Driver now supports adding resource tags to the filestore Instance resources created. Users can provide a comma separated list of tags using the new argument --resource-tags.
Welcome @bharath-b-rh!
It looks like this is your first PR to kubernetes-sigs/gcp-filestore-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/gcp-filestore-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @bharath-b-rh. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Since this has roughly the same approach as https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1377 my comments there can apply to this PR as well :) /ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bharath-b-rh, leiyiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [leiyiz]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@pwschuurman Could you please add lgtm label again, lost it during rebase.
@bharath-b-rh: you cannot LGTM your own PR.
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@bharath-b-rh: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.
In response to this:
/cherry-pick release-1.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@pwschuurman / @leiyiz Could you please help me with cherry picking this change to release-1.6. Thank you!
@mattcary: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.
Error message
status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}In response to this:
/cherry-pick release-1.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.