gcp-filestore-csi-driver icon indicating copy to clipboard operation
gcp-filestore-csi-driver copied to clipboard

Support to add ResoureManagerTags to GCP Filestore resources

Open bharath-b-rh opened this issue 1 year ago • 3 comments

/kind feature

GCP Tags are key-value pairs that are bind to the GCP resources. Unlike currently supported labels, tags are not part of the resource metadata but resource in itself. Tag Keys, Values, Bindings are all discreet resources. Tags are used for defining IAM policy conditions, Organization conditionals policies and integrating with Cloud billing for cost management, which are not supported by labels.

Describe the solution you'd like Able to define the list of resource tags to add to the Filestore resources created by the driver.

Anything else you would like to add: Currently tag resources tag keys and tag values can only be created at Organization and Project level with the required permissions. Tag keys and Tag Values will be created by the user and only the Tag bindings to the filestore resources to be created by the driver and would require(propose) below changes

  1. Driver to accept new argument(--extra-tags) for the list of tags, where tags would be provided as CSV of the form <parent_id>/<key1>/<value1>,...,<parent_id>/<keyN>/<valueN>, where parent_id : Organization or the Project ID where tag key and tag value resource exists. key : Tag key short name value : Tag value short name N : A maximum of 50 tags bindings is allowed for a resource.

  2. Below resources created by the driver requires to be updated with tags

  • Filestore Instance
  • Filestore Backup

Reference Links:

  • https://cloud.google.com/resource-manager/docs/tags/tags-overview
  • https://cloud.google.com/resource-manager/docs/tags/tags-creating-and-managing

bharath-b-rh avatar Aug 02 '23 11:08 bharath-b-rh

/assign @bharath-b-rh

bharath-b-rh avatar Aug 21 '23 07:08 bharath-b-rh

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 26 '24 17:01 k8s-triage-robot

/remove-lifecycle stale

bharath-b-rh avatar Jan 29 '24 14:01 bharath-b-rh

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 28 '24 14:04 k8s-triage-robot

/remove-lifecycle stale

bharath-b-rh avatar Apr 28 '24 17:04 bharath-b-rh