gcp-compute-persistent-disk-csi-driver icon indicating copy to clipboard operation
gcp-compute-persistent-disk-csi-driver copied to clipboard

GCP CSI driver does not emit cloudprovider metrics

Open gnufied opened this issue 3 years ago • 4 comments

The GCP CSI driver does not emit cloudprovider metrics which are emitted by intree cloudprovider.

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/gce/metrics.go

gnufied avatar Mar 19 '21 18:03 gnufied

Is this necessary? Especially since the intree cloud provider is changing, it might be nicer if we allow ourselves to figure out the best way to report k8s vs CSI vs cloud provider latencies based on the current state of the world, rather than replicating obsolete metrics.

Even with migration I'm not sure we should continue supporting those metrics from PD CSI as they probably shouldn't be interpreted the same as they were with the intree driver as the CSI architecture is different (all the external controllers causing different latency behavior).

mattcary avatar Mar 19 '21 18:03 mattcary

I think we should emit cloud provider related metrics in the pd csi driver. This way we get an idea about where the time spend inside the driver. It does not need to be 100% the same name and meaning with the intree cloud provider metric, but we should expose something here.

Jiawei0227 avatar May 12 '21 06:05 Jiawei0227

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 10 '21 06:08 k8s-triage-robot

/lifecycle frozen

mattcary avatar Aug 10 '21 14:08 mattcary