gcp-compute-persistent-disk-csi-driver icon indicating copy to clipboard operation
gcp-compute-persistent-disk-csi-driver copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add support for running tests on confidential VMs that use NVMe

Open pwschuurman opened this issue 11 months ago • 2 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: This adds support to run e2e tests in a configuration that uses NVMe devices. Currently the e2e tests default to using n2 machine family, which uses SCSI by default. Passing in the --enable-confidential-compute flag is a cost effective way to use NVMe (an alternative being running against c3-standard-4 machine type, but this requires additional test refactoring, or skipping tests, as there are restrictions on disk types).

To support toggling with just the binary flag, this also updates the defaults of the test to use n2d as well as a Ubuntu guest OS image instead of Debian.

Support for running "[NVMe]" tagged tests are presubmit will be added in https://github.com/kubernetes/test-infra/pull/32214. These can also be run locally with:

./test/run-e2e-local.sh --enable-confidential-compute

Does this PR introduce a user-facing change?:

NONE

pwschuurman avatar Mar 08 '24 20:03 pwschuurman

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 08 '24 20:03 k8s-ci-robot

/assign @Sneha-at

pwschuurman avatar Mar 11 '24 19:03 pwschuurman

/lgtm

Sneha-at avatar Apr 22 '24 19:04 Sneha-at

/retest

pwschuurman avatar Apr 23 '24 20:04 pwschuurman

@pwschuurman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e eaec6d5ca8515d6582ed9275bac7eba84e4ea273 link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Apr 23 '24 21:04 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 30 '24 02:04 k8s-ci-robot