gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Validate the port field in the BackendObjectReference

Open jpeach opened this issue 3 years ago • 9 comments

https://github.com/kubernetes-sigs/gateway-api/blob/f7b77a78fee608226bae51dfd93d7fb4af060fd7/apis/v1alpha2/object_reference_types.go#L124-L130

When a route specified a BackendObjectReference to a Service, the admission controller should validate that the Port field is present.

Add support for each route type:

  • [x] HTTPRoute - https://github.com/kubernetes-sigs/gateway-api/pull/944
  • [ ] TCPRotue
  • [ ] UDPRoute
  • [ ] TLSRoute

jpeach avatar Nov 18 '21 05:11 jpeach

/assign

tokers avatar Nov 19 '21 04:11 tokers

@tokers Sorry, I didn't see the assign until after I posted the PR. Happy to defer to you if you have a fix pending. I'll be sure to check and assign properly in the future.

jpeach avatar Nov 19 '21 06:11 jpeach

@tokers Sorry, I didn't see the assign until after I posted the PR. Happy to defer to you if you have a fix pending. I'll be sure to check and assign properly in the future.

Oh, don't worry, I haven't start it yet, I'd like to participate the code review :).

tokers avatar Nov 19 '21 06:11 tokers

@tokers Sorry, I didn't see the assign until after I posted the PR. Happy to defer to you if you have a fix pending. I'll be sure to check and assign properly in the future.

Oh, don't worry, I haven't start it yet, I'd like to participate the code review :).

Great!

/assign

jpeach avatar Nov 19 '21 06:11 jpeach

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 21 '22 19:02 k8s-triage-robot

/lifecycle frozen

hbagdi avatar Feb 24 '22 15:02 hbagdi

@jpeach @tokers Are you able to get this over the line? If not, we can unassign you and have this be opened up for other contributors.

hbagdi avatar Feb 24 '22 15:02 hbagdi

@hbagdi I didn't start this task since @jpeach already submitted his PR, I'm happy to continue this task.

tokers avatar Feb 25 '22 01:02 tokers

Despite this issue being quite old, we the maintainers are still pretty convinced that we want to have this functionality in a future release. We are marking this help wanted as we're looking for contributors with strong use cases to help champion and drive this forward.

@tokers if you're still interested in implementing this validation for the remaining APIs, that would be welcomed and appreciated.

shaneutt avatar Aug 16 '22 15:08 shaneutt

Despite this issue being quite old, we the maintainers are still pretty convinced that we want to have this functionality in a future release. We are marking this help wanted as we're looking for contributors with strong use cases to help champion and drive this forward.

@tokers if you're still interested in implementing this validation for the remaining APIs, that would be welcomed and appreciated.

I'm so sorry for the long delay, now I have some time with this issue, I will do this.

tokers avatar Aug 17 '22 09:08 tokers

/assign

tokers avatar Aug 17 '22 09:08 tokers