gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Conditions for Policy Attachment

Open robscott opened this issue 4 years ago • 10 comments

What would you like to be added: As discussed in https://github.com/kubernetes-sigs/gateway-api/pull/715#discussion_r672724388 and https://github.com/kubernetes-sigs/gateway-api/issues/590, any form of status per policy is going to be complex. These conditions may need to be per controller or even per referencing resource (ie policy targeting Route that is also targeted by several Gateways).

Why this is needed: Although each implementation can currently take whichever approach makes the most sense for them, it would be better to standardize on this.

GEP: #713

robscott avatar Jul 26 '21 20:07 robscott

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Oct 24 '21 21:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Nov 23 '21 22:11 k8s-triage-robot

/remove-lifecycle rotten

We will need to address this more, but it needs some more work on actually using Policy.

youngnick avatar Nov 24 '21 05:11 youngnick

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 22 '22 05:02 k8s-triage-robot

/lifecycle frozen

hbagdi avatar Feb 24 '22 15:02 hbagdi

Where are we at with this one? :thinking:

shaneutt avatar Aug 16 '22 15:08 shaneutt

I think we still need this.

/help

robscott avatar Aug 16 '22 15:08 robscott

@robscott: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

I think we still need this.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 16 '22 15:08 k8s-ci-robot

There's been a single status for policy attachment added so far which is great, but for GA this isn't a blocker. We want this feature, but we consider it low priority until v1.0.0/GA is complete and don't believe we will have bandwidth for it until then.

shaneutt avatar Apr 05 '23 22:04 shaneutt

This may be a bit controversial given how complex policy already is, but we have a use case in Istio for adding a PartiallyInvalid PolicyConditionType and UnsupportedValue PolicyConditonReason to mirror the existing type and reason in HTTPRoute.

mikemorris avatar Mar 26 '24 01:03 mikemorris