kubernetes-sigs
build(deps): update dependabot config, bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests
What type of PR is this? /kind cleanup
What this PR does / why we need it:
#4289 has failing git diff because it only bumps the controller-runtime dep in /conformance and not tests
@rikatz it looks like the Dependabot config in https://github.com/kubernetes-sigs/gateway-api/blob/c448aed8ee106eb19559e7bf85363e270f50faa4/.github/dependabot.yml#L7-L8 should be bumping the dep in both directories, so I'm not sure why it was missed but go work sync does expect it.
Which issue(s) this PR fixes:
Fixes #4289
Does this PR introduce a user-facing change?:
yeah, it should be bumping on both directories. This is some dependabot weirdness, it has some issues with go workspaces (from last time I saw it). I will take a look later if there's something that it should be doing and it is not
/lgtm /approve
Thanks!
ah wait, should the bump also contain "sigs.k8s.io" as a pattern? like https://github.com/kubernetes-sigs/gateway-api/blob/c448aed8ee106eb19559e7bf85363e270f50faa4/.github/dependabot.yml#L15
ah wait, should the bump also contain "sigs.k8s.io" as a pattern?
Ah, that's why it worked as expected for https://github.com/kubernetes-sigs/gateway-api/pull/4353!
Added a commit to include sigs.k8s.io in dependabot groups, I think the echo-basic config will always just no-op though, as https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/echo-basic doesn't appear to have any k8s.io deps?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mikemorris, rikatz, robscott
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [robscott]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
