gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

conformance: allow passing GatewayStaticAddresses from CLI

Open howardjohn opened this issue 1 month ago • 7 comments

Otherwise it cannot be passed as these options are required

What type of PR is this?

/area conformance-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


howardjohn avatar Nov 07 '25 23:11 howardjohn

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 07 '25 23:11 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 07 '25 23:11 k8s-ci-robot

Required for what? more context?

LiorLieberman avatar Nov 07 '25 23:11 LiorLieberman

Required for what? more context?

the test needs these set. You can only set them if you call the conformance test from your own custom go test, instead of go test ./conformance. So its impossible to pass the test

howardjohn avatar Nov 08 '25 00:11 howardjohn

/retest

LiorLieberman avatar Nov 24 '25 02:11 LiorLieberman

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify c2dce6bdb923e7aac36c6a76c0206bbb09bb1f8b link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Nov 24 '25 02:11 k8s-ci-robot

@howardjohn can you fix the verify and I will approve?

LiorLieberman avatar Dec 01 '25 23:12 LiorLieberman