conformance: allow passing GatewayStaticAddresses from CLI
Otherwise it cannot be passed as these options are required
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~conformance/OWNERS~~ [howardjohn]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Required for what? more context?
Required for what? more context?
the test needs these set. You can only set them if you call the conformance test from your own custom go test, instead of go test ./conformance. So its impossible to pass the test
/retest
@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-gateway-api-verify | c2dce6bdb923e7aac36c6a76c0206bbb09bb1f8b | link | true | /test pull-gateway-api-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@howardjohn can you fix the verify and I will approve?