gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Improve distribution tests in conformance for HTTPRouteWeight

Open carsontham opened this issue 6 months ago • 4 comments

What type of PR is this?

/area conformance-test

What this PR does / why we need it: Adding entropy to distribution tests for HTTPRouteWeight as per comment https://github.com/kubernetes-sigs/gateway-api/pull/3855#pullrequestreview-2928938545

This is done by reusing the entropy method to create jitter in the requests.

Which issue(s) this PR fixes:

Fixes #3832

Does this PR introduce a user-facing change?:

Improve conformance distribution tests for HTTPRouteWeight

carsontham avatar Jun 24 '25 15:06 carsontham

Hi @carsontham. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 24 '25 15:06 k8s-ci-robot

hey @LiorLieberman! created a follow-up PR for HTTPRouteWeight as per discussed previously. Please take a look, thanks!

carsontham avatar Jun 24 '25 15:06 carsontham

/ok-to-test

mikemorris avatar Jun 24 '25 16:06 mikemorris

@carsontham sorry! just now seeing it.

Can you rebase?

LiorLieberman avatar Aug 06 '25 18:08 LiorLieberman

hey @LiorLieberman, I have rebased it, could you take a look, thanks!

carsontham avatar Aug 10 '25 15:08 carsontham

/cc

LiorLieberman avatar Aug 11 '25 16:08 LiorLieberman

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carsontham, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 11 '25 16:08 k8s-ci-robot