gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard
verified publisher icon kubernetes-sigs

feat(conformance): validate implementation flags

Open mlavacca opened this issue 9 months ago • 7 comments

What type of PR is this?

/area conformance-machinery

What this PR does / why we need it:

The conformance suite implementation-related flags are properly validated.

Which issue(s) this PR fixes:

Fixes #2178

Does this PR introduce a user-facing change?:

The conformance suite implementation-related flags are properly validated.

mlavacca avatar Mar 27 '25 11:03 mlavacca

/retest

mlavacca avatar Mar 27 '25 13:03 mlavacca

/lgtm

youngnick avatar Mar 27 '25 22:03 youngnick

/retest

mlavacca avatar Mar 28 '25 08:03 mlavacca

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 28 '25 09:03 k8s-ci-robot

@youngnick I lost your lgtm as I needed to lint the code. Do you mind taking another look?

mlavacca avatar Apr 03 '25 12:04 mlavacca

/lgtm

youngnick avatar Jul 01 '25 11:07 youngnick

Bit odd to have a function called DefaultOptions that has required flags to be set in it.

sjberman avatar Jul 14 '25 15:07 sjberman