gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Spelling

Open jsoref opened this issue 1 year ago • 3 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/gateway-api/actions/runs/11444311412#summary-31838911907

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gateway-api/actions/runs/11444311702#summary-31838912845

It also fixes the labels of a pair of images to match the word actually used

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

jsoref avatar Oct 21 '24 17:10 jsoref

Welcome @jsoref!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Oct 21 '24 17:10 k8s-ci-robot

Hi @jsoref. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 21 '24 17:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 19 '25 18:01 k8s-triage-robot

/remove-lifecycle stale

jsoref avatar Jan 19 '25 19:01 jsoref

I'm happy to provide a version of this for CI after a version of this merges. It's used by a number majors projects. I'm happy to talk about that on slack/in an issue after this merges.

jsoref avatar Feb 11 '25 21:02 jsoref

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsoref, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 12 '25 12:02 k8s-ci-robot

Thanks @jsoref!

/lgtm

robscott avatar Feb 12 '25 17:02 robscott