gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Add Istio 1.2 conformance report

Open howardjohn opened this issue 1 year ago • 3 comments

What type of PR is this? /area conformance

What this PR does / why we need it: Shows our support for v1.2

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

howardjohn avatar Oct 21 '24 15:10 howardjohn

/lgtm

mikemorris avatar Oct 21 '24 16:10 mikemorris

/lgtm

mikemorris avatar Oct 30 '24 18:10 mikemorris

/approve

arkodg avatar Oct 30 '24 18:10 arkodg

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 30 '24 18:10 k8s-ci-robot

seeing an error

./conformance/reports/v1.2.0/istio-istio/experimental-1.24-default-report.yaml
  125:24    error    no new line character at the end of file  (new-line-at-end-of-file)
 [0;31mTest FAILED: hack/../hack/verify-yamllint.sh 
 [0;31mSummary of failed tests:
[0;31m- hack/../hack/verify-yamllint.sh
make: *** [Makefile:117: verify] Error 1

cc @mikemorris @howardjohn

arkodg avatar Oct 30 '24 19:10 arkodg

/lgtm

mikemorris avatar Oct 30 '24 19:10 mikemorris