Update geps/overview.md - fix a broken link in geps/overview.md
What type of PR is this?
/kind documentation
What this PR does / why we need it: This fixes a broken link in geps/overview.md file.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: joerober Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @joerober. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@joerober Hey, thanks for looking into this! That said -- if I look at https://gateway-api.sigs.k8s.io/geps/overview/, the "graduation criteria" link works for me. Can you doublecheck? or let us know what browser and such you're having an issue with?
@kflynn the link was broken from here: https://github.com/kubernetes-sigs/gateway-api/blob/main/geps/overview.md#5-graduate-the-gep-to-standard
@joerober Ah, I get it. You're viewing the source directly, rather than the rendered pages -- the links are constructed to do the right thing when viewed from the Gateway API website, and it does work from https://gateway-api.sigs.k8s.io/geps/overview/ as it should.
🤔 I don't know of a way to build these so that the links work from both (in the rendered version, this is no longer a Markdown file, so linking directly to the .md isn't appropriate). Any suggestions for how we might better point people looking at the sources to the rendered pages?
/hold
just in case. 🙂
@kflynn Documentation is within Gateway API developer guide: https://gateway-api.sigs.k8s.io/contributing/devguide/#documentation
You are correct that my edit breaks the page. I now see that there is a 'deploy/netlify - Deploy Preview ready!' within this PR (I had to scroll to the bottom of 'All checks')
I'll look at this with the mkdocs live preview server (as described in guide) to if or how to fix in both source and rendered pages.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
Sounds like there's nothing to do here just now so I'll consider this one closed,
/close
However, please feel free to re-open when you're ready!