gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

docs: partial reports can be submitted

Open mlavacca opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind documentation /area conformance

What this PR does / why we need it:

After discussing the possibility of accepting partial reports in https://github.com/kubernetes-sigs/gateway-api/pull/3021, we eventually decided to encourage implementations to start submitting reports even if there is no full conformance. This PR updates the documentation to reflect this final decision.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

mlavacca avatar Jul 02 '24 10:07 mlavacca

/cc @robscott @youngnick @shaneutt

mlavacca avatar Jul 02 '24 10:07 mlavacca

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 02 '24 15:07 k8s-ci-robot

After thinking it over, I do agree that it's better to get partial reports rather than no reports because this will increase our awareness of implementations in the field and enable more opportunities to engage with them.

I do think we may need to adjust the display to accommodate (make sure it's clear, and perhaps delineated when an implementation is reporting partial). I approve,

/approve

However I would like us to make sure we have a follow-up issue in place for considering how the display should look like for this (I don't consider it a blocker though) before we merge:

/hold

Yes, it makes sense. I've opened https://github.com/kubernetes-sigs/gateway-api/issues/3183 to capture this. Let me know if it fits with what you had in mind :)

mlavacca avatar Jul 04 '24 09:07 mlavacca

LGTM

/unhold /cc @robscott @youngnick

shaneutt avatar Jul 04 '24 10:07 shaneutt

All of @robscott's feedback is addressed, going to get this one in.

/lgtm

youngnick avatar Aug 09 '24 04:08 youngnick