gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard
verified publisher icon kubernetes-sigs

chore: added hack/verify-reports.sh script

Open mlavacca opened this issue 1 year ago • 6 comments

What type of PR is this?

/area conformance

What this PR does / why we need it:

Recently, many submitted reports were not compliant with the rules stated in this document. This PR aims to create a script to automatically check the correctness of the uploaded reports and the structure. The following are the checks performed:

  • a README file exists in the project conformance page
  • such a README does not contain broken links
  • the reports are named according to the pattern <experimental | standard>-<semver>-<mode>-report.yaml
  • the project version is a valid semver
  • the GatewayAPIVersion field matches the folder in which the report has been created
  • the GatewayAPIChannel is either "standard" or "experimental"

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

mlavacca avatar Jun 19 '24 10:06 mlavacca

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Jun 19 '24 10:06 k8s-ci-robot

/test pull-gateway-api-verify

mlavacca avatar Jun 19 '24 10:06 mlavacca

/test pull-gateway-api-verify

mlavacca avatar Jun 19 '24 11:06 mlavacca

The CI job is intended to fail until https://github.com/kubernetes-sigs/gateway-api/pull/3168 does not get merged

mlavacca avatar Jun 19 '24 13:06 mlavacca

The CI job is intended to fail until #3168 does not get merged

That PR merged, this one may also need a rebase, we'll see.

/retest

robscott avatar Jun 20 '24 15:06 robscott

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 06 '24 10:08 k8s-ci-robot

@robscott, have you got any more thoughts here? What's our path forward for this one?

youngnick avatar Aug 09 '24 04:08 youngnick

Thanks for the ping on this @youngnick and for all the work @mlavacca! I think this is good to go.

/lgtm

robscott avatar Aug 09 '24 16:08 robscott