gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

[conformance] Properly handle lifecycle of an externally passed gRPC client

Open gauravkghildiyal opened this issue 8 months ago • 3 comments

What would you like to be added: This issue is for tracking the changes discussed in https://github.com/kubernetes-sigs/gateway-api/pull/3130#discussion_r1635872850... tl;dr being that MakeRequestAndExpectEventuallyConsistentResponse() should not close an externally passed gRPC client.

Why this is needed: The same client could be getting used across multiple tests in parallel. Closing the client should be the responsibility of the place where it was created (and not necessarily within the place where the client gets used)

/cc @snehachhabria

gauravkghildiyal avatar Jun 13 '24 19:06 gauravkghildiyal