kubernetes-sigs
Separate Images for Light and Dark Mode
What would you like to be added: As a prerequisite for #2896 to be merged, we'll need to introduce separate images for light and dark mode. This can be done by either converting diagrams to mermaid.js, or creating equivalent dark mode images and following the documentation to specify the mode they're intended to be used with.
Why this is needed: It would be very helpful to have light and dark mode for our docs, but unfortunately our current documentation relies on images that don't work well in dark mode. This work would unblock dark mode capabilities for our documentation.
@robscott: This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
- Why are we solving this issue?
- To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
- Does this issue have zero to low barrier of entry?
- How can the assignee reach out to you for help?
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.
In response to this:
/help
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @robscott , I've checked the images, and it's a lot to process by myself, so it's going to take a while. How about turning this into an umbrella issue and working with contributors to change it?
@jongwooo Sorry I missed this one! If you want to make smaller PRs to just update some of the images, that would be great. I don't think that strictly requires separate/smaller issues, but if you want to create smaller issues, that's also great. Thanks again for the help on this!