gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Conformance Reporting to reflect v1.1.0 release

Open xtineskim opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind documentation /area conformance What this PR does / why we need it: Added a function to get the latest version of Gateway API, reflects the new naming format (<GATEWAY|MESH>-<HTTP|TLS|GRPC>), and a start on how to "archive" the past versions of Gateway API

Currently, for "archiving", each version will have it's own implementation-table-.md. When a new released is cut (tbd frequency by the maintainers), the Comparison link in the nav will point to the latest version. Past releases are then moved to an info drop down - also open to other suggestions if this isn't ideal.

Which issue(s) this PR fixes: Some of follow up tasks related to https://github.com/kubernetes-sigs/gateway-api/issues/3050

Fixes #

Does this PR introduce a user-facing change?:

NONE

xtineskim avatar May 15 '24 19:05 xtineskim

Hi @xtineskim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 15 '24 19:05 k8s-ci-robot

I agree that the dropdown for previous versions isn't ideal, but it's at least clear. Also, rotating this page as part of the release will encourage implementations to get their new conformance test results in quickly, since they won't show up until they do.

youngnick avatar May 16 '24 01:05 youngnick

/ok-to-test

mlavacca avatar May 16 '24 08:05 mlavacca

Thanks @xtineskim! I think once #3137 merges, we'll have 4 reports for v1.1, so if you rebase this PR and regenerate the v1.1 table, we should have enough to merge this.

robscott avatar Jun 18 '24 16:06 robscott

@mlavacca just saw the errors now, it seems like it's tripping since only Istio provides the list of extended Supported Features, whereas all the other implementations don't support them 😅

xtineskim avatar Jun 19 '24 17:06 xtineskim

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, xtineskim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 20 '24 18:06 k8s-ci-robot

Thanks @xtineskim!

/lgtm

robscott avatar Jun 20 '24 20:06 robscott