gateway-api
gateway-api copied to clipboard
[gwctl] Expand the output of gwctl describe httproute
What type of PR is this? /kind gep
What this PR does / why we need it:
This PR introduces an expansion in the output of gwctl describe httproute/httproutes
Which issue(s) this PR fixes:
Fixes #3037
Does this PR introduce a user-facing change?:
The output of `gwctl describe httproute <NAME>` is enhanced further.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: tdn21 / name: Tarun Duhan (ad039bff5c64d30efbef11ce744c14902174fc85, fef66c8b693aa01b96fd318f7deed49cde7d3ee7, 047e7de07e55ff111b3a842703ba46814ea1fa49)
Welcome @tdn21!
It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @tdn21. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/assign
Thanks @tdn21, this seems to be shaping up well. Will do a more detailed review once we take care of the clarifications provided in https://github.com/kubernetes-sigs/gateway-api/issues/3037#issuecomment-2105390648
Thanks for contributing!
Hi @tdn21! Did you get a chance to make the necessary updates?
@gauravkghildiyal, sincere apologies for not getting to this last week. I will update the PR this weekend or upcoming week. Thank you for your patience. 🙇
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: tdn21 Once this PR has been reviewed and has the lgtm label, please ask for approval from gauravkghildiyal. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@gauravkghildiyal thank you for waiting and please take a look whenever you get some time.
Hi @tdn21! Were you able to make some progress here?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @tdn21
We'd like to get this in soon, so I've rebased the commits from this PR and built on top of these commits in https://github.com/kubernetes-sigs/gateway-api/pull/3181.
/close
@gauravkghildiyal: Closed this PR.
In response to this:
Hi @tdn21
We'd like to get this in soon, so I've rebased the commits from this PR and built on top of these commits in https://github.com/kubernetes-sigs/gateway-api/pull/3181.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.