gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Setup goreleaser for gwctl to generate binaries for various platforms

Open gauravkghildiyal opened this issue 9 months ago • 4 comments

What type of PR is this? /kind feature

What this PR does / why we need it:

  • Introduce gwctl version command to print binary information.
    ❯ gwctl version
    Version: 1.0.0-SNAPSHOT-ca344b9a
    Git Commit: ca344b9aa43ad5acc81235b25097fd20d8e97068
    Build Date: 2024-05-01T06:29:53Z
    
  • Setup goreleaser to build binaries for various platforms

NOTES for the reviewer:

  • LICENSE file is added to the gwctl subdirectory so that it get's included in the archives generated by goreleaser.
  • Actual steps of how maintainers will make use of goreleaser to generate the binaries will be added independently (likely after some discussion)

Does this PR introduce a user-facing change?:

NONE

gauravkghildiyal avatar May 01 '24 06:05 gauravkghildiyal

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 01 '24 06:05 k8s-ci-robot

/lgtm /hold for further review though

youngnick avatar May 06 '24 07:05 youngnick

/retest

gauravkghildiyal avatar May 08 '24 04:05 gauravkghildiyal

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 17 '24 11:05 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jul 21 '24 16:07 k8s-triage-robot

I'll take a look into it

/cc

mlavacca avatar Aug 19 '24 17:08 mlavacca

@gauravkghildiyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-crds-validation-1 997fc0771b2e50d9bd8b54685db4376ffd5df945 link true /test pull-gateway-api-crds-validation-1
pull-gateway-api-crds-validation-2 997fc0771b2e50d9bd8b54685db4376ffd5df945 link true /test pull-gateway-api-crds-validation-2
pull-gateway-api-crds-validation-4 997fc0771b2e50d9bd8b54685db4376ffd5df945 link true /test pull-gateway-api-crds-validation-4
pull-gateway-api-crds-validation-3 997fc0771b2e50d9bd8b54685db4376ffd5df945 link true /test pull-gateway-api-crds-validation-3
pull-gateway-api-crds-validation-5 997fc0771b2e50d9bd8b54685db4376ffd5df945 link true /test pull-gateway-api-crds-validation-5

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Sep 10 '24 20:09 k8s-ci-robot

Thanks for the reviews here everyone! Closing this in favor of resolving this within https://github.com/kubernetes-sigs/gwctl.

/close

gauravkghildiyal avatar Sep 20 '24 22:09 gauravkghildiyal

@gauravkghildiyal: Closed this PR.

In response to this:

Thanks for the reviews here everyone! Closing this in favor of resolving this within https://github.com/kubernetes-sigs/gwctl.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 20 '24 22:09 k8s-ci-robot