gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Make gwctl ReferenceGrant aware. Capture any errors observed while constructing the resource graph.

Open gauravkghildiyal opened this issue 9 months ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Use ReferenceGrants to determine if a cross-namespace reference from HTTPRoute to a Backend is valid.
  • Capture incorrect reference errors (like reference not found or not permitted) in the resourceModel. This will be available for consumption by the views.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

gwctl now displays "incorrect" or "not-found" reference errors. It also uses ReferenceGrants to validate if a reference is correct or not (incorrect reference errors are made visible to the user)

/area gwctl

gauravkghildiyal avatar Apr 27 '24 01:04 gauravkghildiyal

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 27 '24 01:04 k8s-ci-robot

/cc @mlavacca

gauravkghildiyal avatar Apr 27 '24 01:04 gauravkghildiyal

/retest

gauravkghildiyal avatar Apr 27 '24 03:04 gauravkghildiyal

Thanks @gauravkghildiyal!

/lgtm

robscott avatar May 02 '24 18:05 robscott

/retest

gauravkghildiyal avatar May 02 '24 20:05 gauravkghildiyal