gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Request to include the certificate/s in the CapturedResponse of the conformance test

Open pramodrj07 opened this issue 10 months ago • 4 comments

Request to include the certificate/s in the CapturedResponse of the conformance test:

To verify the certificate served by the listener/service:

During our testing we found that roundtripper.CapturedResponse does not have a certificates field similar to http.Response(https://github.com/golang/go/blob/master/src/crypto/tls/common.go#L265). It would come in handy for testing as we currently have a wrapper for the same.

or If there is any other way in which this is already done, It would be great to know about it

pramodrj07 avatar Apr 24 '24 20:04 pramodrj07

/assign @snehachhabria

youngnick avatar May 20 '24 22:05 youngnick

@youngnick: GitHub didn't allow me to assign the following users: snehachhabria.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign @snehachhabria

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 20 '24 22:05 k8s-ci-robot

/assign @snehachhabria

snehachhabria avatar May 21 '24 18:05 snehachhabria

Per the discussion on this issue on the meeting, currently there are no tests in the conformance that are asserting on this, however exposing this will allow the extension of tests to make these assertions as well in the future.

If an unexpected cert is provided there will be a TLS connection error and there is no need to validate the cert in this scenario but for success scenarios additional validation will help assert the cert details.

snehachhabria avatar May 24 '24 18:05 snehachhabria

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 22 '24 18:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 21 '24 18:09 k8s-triage-robot