gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

gep-1762: Add `attachTo` to in cluster deployments GEP

Open howardjohn opened this issue 1 year ago • 2 comments

What type of PR is this? /kind gep

What this PR does / why we need it:

This is a followup to https://github.com/kubernetes-sigs/gateway-api/pull/1757. This was stripped out to get things into 1.0

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

A new `spec.infrastructure.attachTo` field has been added to `Gateway` to managed manually deployed infrastructure.

howardjohn avatar Apr 05 '24 15:04 howardjohn

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 05 '24 15:04 k8s-ci-robot

This feels awfully similar to #1863 - it seems like we shouldn't try to tackle one of the problems (Gateway merging) without the other (Gateway Service attachment) given the significant overlap. Unfortunately I think we've run out of time in the v1.1 release cycle to fit something this big in, but I'd like to aim to get both concepts in as one of our first topics post v1.1 release.

robscott avatar Apr 05 '24 16:04 robscott

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jul 21 '24 16:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Aug 20 '24 17:08 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 20 '24 17:08 k8s-ci-robot