gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard
verified publisher icon kubernetes-sigs

conformance - HTTPBackendRef Filter HTTPRouteFilterURLRewrite

Open dprotaso opened this issue 1 year ago • 10 comments

What would you like to be added: Currently there isn't a conformance tests for the HTTPRouteFilterURLRewrite on the HTTPBackendRef

Why this is needed: The feature is Extended but there is no way for implementations to specify that they support this feature. Secondly, a conformance test will verify that the implementation is correctly implemented.

/good-first-issue /help

A good reference on how to write the test please see the following PRs https://github.com/kubernetes-sigs/gateway-api/pulls?q=is%3Apr+author%3Adprotaso+HTTPBackendRef+

dprotaso avatar Apr 03 '24 20:04 dprotaso

@dprotaso: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

What would you like to be added: Currently there isn't a conformance tests for the HTTPRouteFilterURLRewrite on the HTTPBackendRef

Why this is needed: The feature is Extended but there is no way for implementations to specify that they support this feature. Secondly, a conformance test will verify that the implementation is correctly implemented.

/good-first-issue /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 03 '24 20:04 k8s-ci-robot

@dprotaso Can I pick this up?

sharmaansh21 avatar Apr 03 '24 21:04 sharmaansh21

Sure /assign @sharmaansh21

dprotaso avatar Apr 03 '24 21:04 dprotaso

@dprotaso If this is not being worked upon, can you assign this to me

amentee avatar Jun 27 '24 06:06 amentee

@amentee someone is already assigned to the work

dprotaso avatar Jun 27 '24 13:06 dprotaso

Hi @sharmaansh21, how are things going on with this one? In case you need any help, please let us know :)

mlavacca avatar Aug 20 '24 07:08 mlavacca

@mlavacca My apologies; I missed the fact that this was assigned to me. I will pick it up this week.

sharmaansh21 avatar Aug 20 '24 11:08 sharmaansh21