gateway-api
gateway-api copied to clipboard
kubernetes-sigs
GEP-2891: HTTP Cookie Match
What type of PR is this? /kind gep
What this PR does / why we need it:
This GEP proposes to add a new field HTTPCookieMatch to HTTPRouteMatch.
Moreover, a new match type List is added. Matches if the value of the cookie with name field is present in a list of strings. This match type List can be applied to serving HTTPHeaderMatch and HTTPQueryParamMatch as well.
Which issue(s) this PR fixes: Fixes #2891
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lianglli Once this PR has been reviewed and has the lgtm label, please assign youngnick for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: lianglli / name: Liang (a2f80bce53416baa2a3ae8c9a80d6a7f7eba4f67, 7558506f4617c85b689a65e0164eeb46e4742064, ed0ebb6bb1ee6a18444be4379a3c8ece52c6f69d, 80ecd9fff3aa4b104d409fe587b1c2a6fcf94001, 1120d38b63ffd01b67a38c532ce108e68341ed9e, 4308fec870c84f16ab8d3d6e00e475ab9939775c, 81a36459ecb0c17cbec0efa0ae24c544ffd995bd, 7a1df04785b6518e1e6e67fabbf5124e9f9f4d0b, 85f60367df93951fa0f0b6368d6f030fa4a3cfc3)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @lianglli!
It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @lianglli. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:
- 1120d38 fix #2891 add support for cookie in the HTTPRouteMatch API
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Hey @lianglli, thanks for writing this up! We're currently very focused on getting v1.1 out the door, but once we get that release out, we'll make sure to spend some time reviewing this GEP.
/ok-to-test
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:
- 1120d38 fix #2891 add support for cookie in the HTTPRouteMatch API
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/cc @youngnick @robscott @shaneutt
We need to come back around to this and review now when we get some time.
@lianglli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-gateway-api-crds-validation-4 | 81a36459ecb0c17cbec0efa0ae24c544ffd995bd | link | true | /test pull-gateway-api-crds-validation-4 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.