Add conformance test for GRPCRouteFilterRequestHeaderModifier

[pleshakov]

What would you like to be added: A conformance test for https://github.com/kubernetes-sigs/gateway-api/blob/729d38f9bf17ff72d17f0148452416551296f67c/apis/v1alpha2/grpcroute_types.go#L436

Why this is needed:

Increase conformance feature coverage of GRPCRoute

[yashvardhan-kukreja]

Hi @pleshakov I would love to contribute this.

[yashvardhan-kukreja]

/assign

[yashvardhan-kukreja]

@pleshakov IIUC, isn't this test already achieving what this issue expects? - https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-request-header-modifier.go

[pleshakov]

Hi @yashvardhan-kukreja

Hi @pleshakov I would love to contribute this.

that's great! I'd recommend to wait until any of the maintainers replied that this issue makes sense or ask this question in the gateway api slack channel https://gateway-api.sigs.k8s.io/contributing/#communications , to double check this work is needed.

@pleshakov IIUC, isn't this test already achieving what this issue expects? - https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-request-header-modifier.go

that tests works for HTTPRoutes. However, there is no such test for GRPCRoutes.

I'd also double check with @gnossen who authored first GRPC conformance tests https://github.com/kubernetes-sigs/gateway-api/pull/2745

[yashvardhan-kukreja]

that tests works for HTTPRoutes. However, there is no such test for GRPCRoutes.

Gotcha, that makes sense :)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[sjberman]

@yashvardhan-kukreja have you been working on this?