gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard
verified publisher icon kubernetes-sigs

Promote Gateway for Mesh (GAMMA) to Standard

Open howardjohn opened this issue 1 year ago • 1 comments

What type of PR is this?

/kind gep

What this PR does / why we need it: This PR raises Gateway API for Mesh to "Standard" channel.

What is included:

  • GEP-1426 (Routes binding to service) and GEP-1686 (conformance tests for mesh)
  • Updated various docs to declare stable.

Followup needed:

  • Blog post announcement

What is not included:

  • Changes to any tests; we already have existing conformance for mesh, and the feature is already called MeshCoreFeatures so I don't think we need to change anything there. In the future, we may add experimental features to Mesh, at which point we can make a new set of features like MeshExperimentalFeatures or similar.
  • Changes to any Go/CRD APIs beyond docs. The Gateway for Mesh work did not introduce any API changes. Instead it just introduced new ways to use the existing APIs with corresponding documentation changes to remove the 'Experimental' signifier.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The Gateway API for Mesh ("GAMMA") support has been promoted to the Standard Channel

howardjohn avatar Mar 14 '24 17:03 howardjohn

I think it's time! /approve

keithmattix avatar Apr 02 '24 14:04 keithmattix

Hit it! 🙂 /approve

kflynn avatar Apr 02 '24 14:04 kflynn

Although I definitely still want to see continued evolution and growth of this pattern, I agree that it's time to formally graduate this pattern to GA to reflect the widespread implementation and overall stability of this pattern. Thanks to everyone that helped make this a reality!

/approve

robscott avatar Apr 05 '24 00:04 robscott

/lgtm

youngnick avatar Apr 05 '24 00:04 youngnick

/hold cancel

looks like this was added on the pr creation and not intended

howardjohn avatar Apr 05 '24 02:04 howardjohn

/retest-required

keithmattix avatar Apr 05 '24 02:04 keithmattix

We usually add a hold for GEP or similar scope changes now, just to avoid accidental merges (since if someone with approver makes a PR, it's automatically approved). This happened a few times before 😨 .

Looks like this needs a make generate before the tests will pass.

youngnick avatar Apr 05 '24 02:04 youngnick

Looks like this needs a make generate before the tests will pass.

Should to be good this time!

howardjohn avatar Apr 05 '24 03:04 howardjohn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: howardjohn, keithmattix, kflynn, michaelbeaumont, mikemorris, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 05 '24 13:04 k8s-ci-robot

/hold cancel

mikemorris avatar Apr 05 '24 13:04 mikemorris

Woo!! :tada: :tada: :tada: :tada: :tada: :tada: :tada:

Thanks everyone for the years of hard work on getting this passed the finish line!

howardjohn avatar Apr 05 '24 14:04 howardjohn

Thanks for writing the PR on this one, @howardjohn! 🙂

kflynn avatar Apr 05 '24 16:04 kflynn