gateway-api
gateway-api copied to clipboard
kubernetes-sigs
HTTPBackendRef ResponseHeaderModifier Conformance Test
What type of PR is this? /kind cleanup /kind test /area conformance
What this PR does / why we need it:
This adds test coverage for an extended feature - HTTPBackendRef being able to support the responseHeader filter
Which issue(s) this PR fixes: N/A
Does this PR introduce a user-facing change?:
NONE
adding approvers /assign @arkodg @mlavacca @sunjayBhatia
adding reviewers /cc @LiorLieberman @michaelbeaumont @Xunzhuo
Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @sunjayBhatia @michaelbeaumont @LiorLieberman @Xunzhuo
Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @sunjayBhatia @michaelbeaumont @LiorLieberman @Xunzhuo
Hoping this lands in v1.1 this week
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dprotaso Once this PR has been reviewed and has the lgtm label, please assign robscott for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks for the work on this @dprotaso! Before we merge something like this, I think it would be good to figure out https://github.com/kubernetes-sigs/gateway-api/issues/3009.
/hold
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@dprotaso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-gateway-api-crds-validation-5 | bd8f09cdaf2bd60a137ede18302744ae8ca1bfcc | link | true | /test pull-gateway-api-crds-validation-5 |
| pull-gateway-api-crds-validation-3 | bd8f09cdaf2bd60a137ede18302744ae8ca1bfcc | link | true | /test pull-gateway-api-crds-validation-3 |
| pull-gateway-api-crds-validation-1 | bd8f09cdaf2bd60a137ede18302744ae8ca1bfcc | link | true | /test pull-gateway-api-crds-validation-1 |
| pull-gateway-api-crds-validation-4 | bd8f09cdaf2bd60a137ede18302744ae8ca1bfcc | link | true | /test pull-gateway-api-crds-validation-4 |
| pull-gateway-api-crds-validation-2 | bd8f09cdaf2bd60a137ede18302744ae8ca1bfcc | link | true | /test pull-gateway-api-crds-validation-2 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.