gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

HTTPBackendRef RequestHeaderModifier Conformance Test

Open dprotaso opened this issue 1 year ago • 2 comments

What type of PR is this? /kind cleanup /kind test /area conformance

What this PR does / why we need it:

This adds test coverage for an extended feature - Supporting request header modification on the HTTPBackendRef

Which issue(s) this PR fixes: N/A

Does this PR introduce a user-facing change?:

NONE

dprotaso avatar Feb 26 '24 22:02 dprotaso

adding approvers /assign @arkodg @mlavacca @sunjayBhatia

adding reviewers /cc @LiorLieberman @michaelbeaumont @Xunzhuo

dprotaso avatar Mar 07 '24 22:03 dprotaso

Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @sunjayBhatia @michaelbeaumont @LiorLieberman @Xunzhuo

dprotaso avatar Apr 01 '24 20:04 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 03 '24 11:04 k8s-ci-robot

Looks good to me, which implementation did you test it with? /lgtm

This passes with Contour and Istio

dprotaso avatar Apr 03 '24 11:04 dprotaso