gateway-api
gateway-api copied to clipboard
HTTPRouteHostnameIntersection - Add a wildcard listener test case
What type of PR is this? /kind cleanup /kind test /area conformance
What this PR does / why we need it:
The spec on the Gateway states if hostname is omitted all host names must match. This expands the HTTPRouteHostNameIntersection test to assert this test case
spec ref: https://github.com/kubernetes-sigs/gateway-api/blob/334604c991f591a24b8fb0623693e845ae84867f/apis/v1/gateway_types.go#L244
Which issue(s) this PR fixes: N/A
Does this PR introduce a user-facing change?:
NONE
@dprotaso at first glance, this seems like it overlaps with https://github.com/kubernetes-sigs/gateway-api/pull/2669, can you clarify if/how it's different?
That linked test is 'Extended' - we don't have a 'Core' test for the functionality I quoted from the spec
I was looking for a 'core' test that:
- Doesn't specify a hostname in the Gateway
- Has unique hostnames names in the HTTPRoute
- Requests succeed for hostnames defined in the HTTPRoute
- Requests fail for hostnames not defined in the HTTPRoute
adding approvers /assign @arkodg @mlavacca @sunjayBhatia
adding reviewers /cc @LiorLieberman @michaelbeaumont @Xunzhuo
Conformance approvers - can I get review please @arkodg @mlavacca @sunjayBhatia
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: arkodg, dprotaso, michaelbeaumont, Xunzhuo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~conformance/OWNERS~~ [arkodg]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment