gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Conformance test for HTTPRoute weights

Open dprotaso opened this issue 1 year ago • 3 comments

What type of PR is this? /kind cleanup /kind test /area conformance

What this PR does / why we need it:

There currently isn't a conformance test for weighted routing. This is a core feature for HTTPRoute.

Which issue(s) this PR fixes: N/A

Does this PR introduce a user-facing change?:

NONE

dprotaso avatar Feb 26 '24 16:02 dprotaso

rebased

dprotaso avatar Mar 05 '24 22:03 dprotaso

adding approvers and reviewers for input here on approach - see the discussion here - https://github.com/kubernetes-sigs/gateway-api/pull/2814#discussion_r1503473000

/assign @arkodg @mlavacca @sunjayBhatia /cc @LiorLieberman @michaelbeaumont @Xunzhuo

dprotaso avatar Mar 07 '24 23:03 dprotaso

Conformance reviewers/approvers - Can I get review please @arkodg @LiorLieberman @michaelbeaumont @mlavacca @sunjayBhatia @Xunzhuo

dprotaso avatar Apr 01 '24 20:04 dprotaso

There's a go.mod change so this requires top level maintainers to approve

/unassign @sunjayBhatia @arkodg @mlavacca /assign @robscott @shaneutt @youngnick

dprotaso avatar Apr 05 '24 16:04 dprotaso

/lgtm /approve

robscott avatar Apr 15 '24 22:04 robscott

error seems unrelated to PR

level=error msg="Running error: context loading failed: no go files to analyze" [0;31mTest FAILED: hack/../hack/verify-golint.sh

/retest

dprotaso avatar Apr 15 '24 23:04 dprotaso

Need to merge/rebase main

dprotaso avatar Apr 15 '24 23:04 dprotaso

rebased and ran go mod tidy

dprotaso avatar Apr 15 '24 23:04 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, dprotaso, mlavacca, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 16 '24 12:04 k8s-ci-robot