gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Add route port attachment conformance test

Open frankbu opened this issue 1 year ago • 5 comments
trafficstars

What type of PR is this?

/kind test /area conformance

What this PR does / why we need it:

Conformance test needed to promote GEP-957 to standard.

Tested and passes with Istio implementation.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

frankbu avatar Feb 15 '24 22:02 frankbu

Since it looks like Istio is already passing these tests, we need a couple more implementations to also pass these tests to consider this feature ready to graduate to standard channel. Can a few others test this out?

/cc @arkodg @pleshakov @sunjayBhatia

robscott avatar Feb 15 '24 22:02 robscott

@robscott: GitHub didn't allow me to request PR reviews from the following users: pleshakov.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Since it looks like Istio is already passing these tests, we need a couple more implementations to also pass these tests to consider this feature ready to graduate to standard channel. Can a few others test this out?

/cc @arkodg @pleshakov @sunjayBhatia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 15 '24 22:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 23 '24 21:02 k8s-ci-robot

So far we've gotten confirmation that these tests pass on Istio and Contour. We just need one more implementation to confirm that these tests pass for them for this feature to graduate to standard.

@arkodg, @mlavacca, or @pleshakov can any of you confirm if these tests pass on your implementation(s)?

robscott avatar Mar 05 '24 04:03 robscott

Updates #957

youngnick avatar Mar 11 '24 04:03 youngnick

Test passes with Envoy Gateway! 😃

cc @arkodg @robscott

frankbu avatar Mar 28 '24 20:03 frankbu

Thanks @frankbu! Do you mind making a follow up PR to formally graduate this GEP to standard and remove the experimental tags around the fields?

/lgtm

robscott avatar Mar 28 '24 20:03 robscott

Thanks @frankbu! Do you mind making a follow up PR to formally graduate this GEP to standard and remove the experimental tags around the fields?

Already done: #2777

frankbu avatar Mar 28 '24 21:03 frankbu