gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Conformance supported-features flag help string should include all valid values.

Open briantkennedy opened this issue 2 years ago • 3 comments

What would you like to be added:

https://github.com/kubernetes-sigs/gateway-api/blob/73f20f4ae4ab46a4a2ea52718fdbdef1a6726376/conformance/utils/flags/flags.go#L30C127-L30C127

The help string for -supported-features should include all valid feature values.

Why this is needed:

Users should not need to inspect source code to obtain the valid values.

briantkennedy avatar Aug 18 '23 19:08 briantkennedy

Hi, @shaneutt ,

Do you mean that we should add these support features into description? https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/suite/features.go#L27

Would you like to assign this task to me?

pegasas avatar Aug 23 '23 02:08 pegasas

Hey @pegasas, yep, I think the goal here is to add the full list of possible features (AllFeatures) as a comma separated list to the description of the flag here: https://github.com/kubernetes-sigs/gateway-api/blob/73f20f4ae4ab46a4a2ea52718fdbdef1a6726376/conformance/utils/flags/flags.go#L30. Thanks for volunteering!

/assign @pegasas

robscott avatar Aug 23 '23 03:08 robscott

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Sep 26 '24 14:09 k8s-triage-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Dec 25 '24 15:12 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jan 24 '25 15:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Feb 23 '25 15:02 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 23 '25 15:02 k8s-ci-robot