gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

https://gateway-api.sigs.k8s.io/references/spec renders code snippets improperly

Open pmalek opened this issue 3 years ago • 1 comments

It seems that the tooling responsible for generating the source for https://gateway-api.sigs.k8s.io/references/spec is not doing it properly for code snippets (e.g. yaml manifests)

Taking a look at https://github.com/kubernetes-sigs/gateway-api/blob/ff862f153f1c3c014ddf84a1194bc44982d027e2/site-src/api-types/httproute.md#matches the manifest looks correct

image

Although what's rendered at https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io%2fv1beta1.HTTPRouteRule doesn't look right

image

Note the squashed list items.

Not sure how feasible it is to address this.

pmalek avatar Oct 14 '22 08:10 pmalek

Thanks for filing this @pmalek! Hopefully someone can find a solution to this that also passes linting. If not, we may just need to find an alternative to inline YAML snippets. We ran into similar problems in https://github.com/kubernetes-sigs/gateway-api/pull/1416.

robscott avatar Oct 15 '22 00:10 robscott

/assign

kundan2707 avatar Oct 24 '22 06:10 kundan2707

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 08 '23 11:02 k8s-triage-robot

Hi @kundan2707 👋

Wanted to check in on this one: are you still planning on doing this, and do you need any assistance from us? If not that's totally fine just let us know and we can unassign you 🖖

shaneutt avatar Feb 22 '23 15:02 shaneutt

/remove-lifecycle stale

kundan2707 avatar Jul 19 '23 12:07 kundan2707

@shaneutt can you help me to get path or any document related to tooling which is responsible for generation of this document?

kundan2707 avatar Jul 19 '23 12:07 kundan2707

What I usually do when I need to update the site is make my changes (e.g. in site-src/) and then make a draft PR, so that netlify can build it for me and provide a demo URL I can test my changes at.

shaneutt avatar Jul 19 '23 15:07 shaneutt

@shaneutt thanks I will make change and push draft PR soon.

kundan2707 avatar Jul 19 '23 17:07 kundan2707

Closing this in favor #2555.

robscott avatar Jan 17 '24 01:01 robscott