gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Promote ReferenceGrant to Beta

Open nathancoleman opened this issue 2 years ago • 3 comments

What type of PR is this?

/kind feature /kind api-change

What this PR does / why we need it: Graduates the ReferenceGrant resource to v1beta1 and the stable release channel

Which issue(s) this PR fixes:

Fixes #1448

Does this PR introduce a user-facing change?:

Promotes ReferenceGrant to the v1beta1 API and the stable release channel

nathancoleman avatar Oct 12 '22 19:10 nathancoleman

Hi @nathancoleman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 12 '22 19:10 k8s-ci-robot

Thanks for working on this @nathancoleman! I'm going to hold off on reviewing this since it's still in draft state, but leave another comment here when it's ready for review.

/ok-to-test

robscott avatar Oct 13 '22 03:10 robscott

@robscott can you take a look when you get a moment?

nathancoleman avatar Oct 19 '22 19:10 nathancoleman

Others feel free to review. It seems that re-requesting a review from Rob removes all other reviewers

nathancoleman avatar Oct 31 '22 16:10 nathancoleman

@robscott to you for review when you get a moment

nathancoleman avatar Oct 31 '22 19:10 nathancoleman

Thanks @nathancoleman! This change LGTM, but I want to get another maintainer to sign off before merging since this represents graduating a resource to beta.

/approve /assign @shaneutt @youngnick

robscott avatar Nov 03 '22 21:11 robscott

@shaneutt what change are you looking for there? I don't see anything in the GEP template or other GEPs that looks related

nathancoleman avatar Nov 04 '22 15:11 nathancoleman

You'll wanna update the GEP status here to standard:

https://github.com/kubernetes-sigs/gateway-api/blob/2f7ab6846818c1632f163a1f97b28199ec36fa8f/site-src/geps/gep-709.md?plain=1#L4

And move it under "Standard" here:

https://github.com/kubernetes-sigs/gateway-api/blob/2f7ab6846818c1632f163a1f97b28199ec36fa8f/mkdocs.yml#L86

Also I would recommend taking one quick pass over the GEP just to make sure everything in it is accurate to the current API state, and if not update it to be in sync.

shaneutt avatar Nov 04 '22 15:11 shaneutt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nathancoleman, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [robscott,shaneutt]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 05 '22 01:11 k8s-ci-robot