gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

conformance: listener references invalid secret

Open mlavacca opened this issue 3 years ago • 3 comments

What type of PR is this?

/kind feature

What this PR does / why we need it: A new conformance test case has been added to ensure that whenever a listener references an unexisting secret as CertificateRef, the Condition ResolvedRefs is set as failed with the reason InvalidCertificateRef.

Which issue(s) this PR fixes:

Fixes #1318

Does this PR introduce a user-facing change?:

NONE

mlavacca avatar Aug 16 '22 08:08 mlavacca

Hi @mlavacca. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 16 '22 08:08 k8s-ci-robot

/ok-to-test

shaneutt avatar Aug 16 '22 14:08 shaneutt

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 16 '22 14:08 k8s-ci-robot