gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Backport conformance fix for Listener condition reason ListenerReasonRefNotPermitted

Open sunjayBhatia opened this issue 3 years ago • 2 comments

What would you like to be added: Backport changes from https://github.com/kubernetes-sigs/gateway-api/pull/1305 to release 0.5.x

Why this is needed: Implementations that are updated to pass conformance tests on main now fail on the Gateway API 0.5.0 conformance tests (and vice versa). Since #1305 is a bug fix It would be great to ensure the latest release line is patched along with main

If this is an acceptable change, can start the process of making a PR to backport the change, will need some guidance on what to do if there is not yet a process around patch releases

(This in particular applies to Contour's implementation, see: https://github.com/projectcontour/contour/pull/4664)

sunjayBhatia avatar Aug 15 '22 16:08 sunjayBhatia

Good point. I think we should release a v0.5.1 with the updates to our conformance tests that have merged recently.

robscott avatar Aug 15 '22 16:08 robscott

I'm on board with a v0.5.1 for the recent conformance test fixes :+1:

An argument may be made about not doing this in a patch release and if we were v1 I would 100% agree, but we're v0 and semver has this to say about it: Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

shaneutt avatar Aug 15 '22 18:08 shaneutt

I don't see a 0.5.x release branch yet, I assume that needs to be created before we can do a backport? (sidebar, maybe we need a separate issue to document the backport process for maintainers and contributors if it doesnt exist already?)

sunjayBhatia avatar Aug 17 '22 20:08 sunjayBhatia

I've created release-0.5 (analogous to release-0.4) :+1:

And yes, feel free to create an issue for creating backport procedure and documentation.

shaneutt avatar Aug 17 '22 20:08 shaneutt

I'm +1 on a patch release as well.

youngnick avatar Aug 18 '22 04:08 youngnick

submitted #1351 to backport the commit

sunjayBhatia avatar Aug 22 '22 15:08 sunjayBhatia

Thanks @sunjayBhatia!

robscott avatar Aug 22 '22 20:08 robscott