gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

conformance: refactor listenersMatch and parentsMatch helpers

Open FlorentFlament opened this issue 2 years ago • 10 comments

Fixes https://github.com/kubernetes-sigs/gateway-api/issues/1142

Conformance helpers has been refactored to enable future improvements, like matching arbitrarily ordered elements of lists for listenersMatch and parentsMatch.

What type of PR is this? /kind feature

What this PR does / why we need it: Deals with an opened issue #1142. This will enable further improvements for compliance testing.

Which issue(s) this PR fixes: Fixes #1142

Does this PR introduce a user-facing change?: None


FlorentFlament avatar Jun 07 '22 13:06 FlorentFlament

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: FlorentFlament / name: Florent Flament (f9a0ad3a77cd0f664441ec20c961f0fa51a62f95)

Welcome @FlorentFlament!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jun 07 '22 13:06 k8s-ci-robot

Hi @FlorentFlament. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 07 '22 13:06 k8s-ci-robot

/easycla

FlorentFlament avatar Jun 07 '22 13:06 FlorentFlament

/ok-to-test /assign

mikemorris avatar Jun 29 '22 18:06 mikemorris

Hi @FlorentFlament, could you rebase? I had a really quick look and I think this is pretty close, although we may need to put a generics policy into CONTRIBUTING. I'll put that on the agenda for next week's meeting.

youngnick avatar Sep 05 '22 23:09 youngnick

Hi Nick, Sure, I can rebase this PR. Don't hesitate to tell me if this requires further rework, or whether this is still relevant. Regards

FlorentFlament avatar Sep 06 '22 07:09 FlorentFlament

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FlorentFlament Once this PR has been reviewed and has the lgtm label, please assign robscott for approval by writing /assign @robscott in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 06 '22 11:09 k8s-ci-robot

Refs https://github.com/kubernetes-sigs/gateway-api/issues/1388 re adding an explicit generics policy.

mikemorris avatar Sep 16 '22 00:09 mikemorris

@FlorentFlament: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 04 '22 12:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 02 '23 12:01 k8s-triage-robot

@FlorentFlament it's been a long time since we've heard back from you on this, are you still available to finish this up?

If not that's OK, and we still appreciate your time but if you need to drop it, or if we don't hear back from you we'll open it up for someone else to finish it, just let us know.

shaneutt avatar Jan 31 '23 14:01 shaneutt

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 02 '23 14:03 k8s-triage-robot

This is quite old and we haven't gotten a response back from the author so we're going to close this for now. #1142 has been made available again for someone else to take on if they'd like to continue this work (or if the author returns we can re-open this and continue).

shaneutt avatar Mar 08 '23 17:03 shaneutt